Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] use absolute path for @types output directory #19138

Merged
merged 1 commit into from Apr 24, 2022
Merged

[Vue] use absolute path for @types output directory #19138

merged 1 commit into from Apr 24, 2022

Conversation

diosmosis
Copy link
Member

Description:

...so it does not change if plugins define their own tsconfig.json.

Also fix the MobileMessaging umd.metadata.json file, which should have a dependency for ScheduledReports.

Review

@diosmosis
use absolute path for @types output directory so it does not change i…
98b73a3 
…f plugins define their own tsconfig.json
@diosmosis diosmosis added the Needs Review PRs that need a code review label Apr 24, 2022
@diosmosis diosmosis added this to the 4.10.0 milestone Apr 24, 2022
@sgiehl sgiehl merged commit b0ed828 into 4.x-dev Apr 24, 2022
@sgiehl sgiehl deleted the vue-abs-path-types-dir branch April 24, 2022 19:43
@justinvelluppillai justinvelluppillai added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

@peterhashair peterhashair Awaiting requested review from peterhashair

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @sgiehl @justinvelluppillai