@HCl-not-HCi opened this Pull Request on April 23rd 2022 Contributor

Description:

I found another location where the accessibility of the global.ini.php is checked despite the enable_required_directories_diagnostic option is disabled in the config (the other case was fixed in #19031).
I just copied the changes over from #19031 to here.

Fixes #18967

Review

@bx80 commented on April 27th 2022 Contributor

Hi @HCl-not-HCi, thanks for submitting this PR, much appreciated! :slightly_smiling_face:

The change looks good to me, the only minor thing would be adding a use statement for the GeneralConfig class:

use Piwik\Config\GeneralConfig;

If you get a chance to commit that then I'll get this merged into the development branch :+1:

@HCl-not-HCi commented on April 28th 2022 Contributor

Oh, I've overseen that. Thanks for letting me know @bx80
Now it should be ready to merge 👍

This Pull Request was closed on April 28th 2022
Powered by GitHub Issue Mirror