Respect enable_required_directories_diagnostic option in server info diagnostics #19137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @HCl-not-HCi, thanks for submitting this PR, much appreciated! 🙂 The change looks good to me, the only minor thing would be adding a use statement for the GeneralConfig class: If you get a chance to commit that then I'll get this merged into the development branch 👍 |
|
Oh, I've overseen that. Thanks for letting me know @bx80 |
justinvelluppillai
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I found another location where the accessibility of the
global.ini.phpis checked despite theenable_required_directories_diagnosticoption is disabled in the config (the other case was fixed in #19031).I just copied the changes over from #19031 to here.
Fixes #18967
Review