Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix adding goal when no goal exists #19136

Merged
merged 5 commits into from Apr 25, 2022
Merged

Fix adding goal when no goal exists #19136

merged 5 commits into from Apr 25, 2022

Conversation

MichaelRoosz
Copy link
Contributor

This fixes #19124

@MichaelRoosz
Copy link
Contributor Author

Update:
I also had some

The string General_Description was not loaded in javascript. Make sure it is added in the Translate.getClientSideTranslationKeys hook.

errors, so I added all the missing js translation keys.

@sgiehl sgiehl added this to the 4.10.0 milestone Apr 25, 2022
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Apr 25, 2022
sgiehl
sgiehl approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to fix the issue 👍

@sgiehl sgiehl merged commit 3359376 into matomo-org:4.x-dev Apr 25, 2022
@MichaelRoosz MichaelRoosz deleted the fix-add-goals branch October 29, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.10.0
Development

Successfully merging this pull request may close these issues.

Fix error when adding new goals if no previous goals exist for website/measurable
2 participants
@MichaelRoosz @sgiehl