@Demichev opened this Issue on April 21st 2022

Summary

May I ask not popular but small feature? We are using MatomoTracker class to emulate user page visits when payment callback is executed. MatomoTracker is poorly virtualized so I overrode the whole sendRequest() method just to replace proxy (getProxy() method is private), add CURLOPT_HTTPHEADER to curl and ['http']['header'] to $stream_options.
It works but each time Matomo is updated I compare code, make changes, etc.
Can you make getProxy() protected and add empty protected methods for curl options/stream_options?

Your Environment

  • Matomo Version: 4.7.1
@bx80 commented on April 22nd 2022 Contributor

Hi @Demichev, I can't see any obvious problem with exposing some protected methods. It might be a while before this gets prioritized though as we've got a back log of issues.

@Demichev commented on April 22nd 2022

I understand that it will have a very low priority. Just hope that it requires so small changes that it can be done reasonably soon.

@sgiehl commented on April 25th 2022 Member

@Demichev If you have some time to provide a Pull Request with the required changes, we are happy to review and merge it.
Note: the changes needs to be proposed here: https://github.com/matomo-org/matomo-php-tracker

@Demichev commented on May 10th 2022

Pull request is sent. Sorry, I am not sure about coding/comments standards for this project.

Powered by GitHub Issue Mirror