Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix display issue with z-index for widgets that use tables with embedded dashboards #19125

Closed
scottf-tvw opened this issue Apr 20, 2022 · 1 comment · Fixed by #19155
Closed

Fix display issue with z-index for widgets that use tables with embedded dashboards #19125

scottf-tvw opened this issue Apr 20, 2022 · 1 comment · Fixed by #19155
Assignees
@sgiehl
Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.10.0

Comments

@scottf-tvw
Copy link

scottf-tvw commented Apr 20, 2022 •
edited

table in widgets that use tables embedded dashboards have a z-index of 10 causing overflow issues with other components in the view.

Expected Behavior

Table headers should not contain a z-index higher than other root components. Thus not blocking menu's and or other nearby reports when overflow is triggered on resizing

Current Behavior

resizing a dashboard with other components may cause the of a widget using a table to overflow into the view over other widgets. Menus that are activated will be obscured by the portion of a widget.

Possible Solution

remove z-index = 10 from the

Steps to Reproduce (for Bugs)

create a dashboard with table type views. load as an iframe and open a menu.

Context

it looks horrible and unprofessional for a white labeled system, lie we are paying for. Also not interested in adding css overrides for something like this.

Your Environment

  • Matomo Version: 4.9
  • PHP Version: 7.4.3
  • Server Operating System: cluster of ubuntu 20 lts in AWS
  • Additionally installed plugins:
    Whitelabel, custom reports and media analytics
  • Browser: ANY
  • Operating System: ANY
    Screen Shot 2022-04-20 at 4 13 45 PM
    Screen Shot 2022-04-20 at 4 06 37 PM
@scottf-tvw scottf-tvw added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Apr 20, 2022
@bx80 bx80 added Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. Needs priority decision This issue may need to be added to the current milestone by Product Manager and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Apr 22, 2022
@bx80
Copy link
Contributor

bx80 commented Apr 22, 2022

Hi @scottf-tvw, thanks for reporting this. I've recreated the issue and can confirm that removing the z-index from the table header prevents the broken layout.

@justinvelluppillai justinvelluppillai added this to the 4.9.1 milestone Apr 22, 2022
@justinvelluppillai justinvelluppillai removed the Needs priority decision This issue may need to be added to the current milestone by Product Manager label Apr 22, 2022
@justinvelluppillai justinvelluppillai modified the milestones: 4.9.1, 4.10.0 Apr 26, 2022
@sgiehl sgiehl self-assigned this Apr 28, 2022
@sgiehl sgiehl mentioned this issue Apr 28, 2022
Merged
11 tasks
@justinvelluppillai justinvelluppillai changed the title table <thead> in widgets that use tables embedded dashboards have a z-index of 10 causing overflow issues with other components in the view Fix display issue with z-index for widgets that use tables with embedded dashboards May 8, 2022
@bx80 bx80 mentioned this issue May 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.10.0
Development

Successfully merging a pull request may close this issue.

Ensure top control elements are displayed above reports on embeded dashboard matomo-org/matomo
4 participants
@justinvelluppillai @sgiehl @scottf-tvw @bx80