Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated String.prototype.substr() #19111

Merged
merged 1 commit into from May 3, 2022
Merged

Replace deprecated String.prototype.substr() #19111

merged 1 commit into from May 3, 2022

Conversation

CommanderRoot
Copy link
Contributor

Description:

String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated.
.substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.

Review

.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated

Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
@sgiehl sgiehl added the Needs Review PRs that need a code review label Apr 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2022

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label May 3, 2022
@sgiehl sgiehl added this to the 4.11.0 milestone May 3, 2022
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good.
@CommanderRoot for future PRs it would be awesome if you could build the vue files if there are changes done in such. This can be easily achieved by running ./console vue:vuild.
I'll merge this now nevertheless and push the updated vue files afterwards.
Thanks for your contribution 🎉

@sgiehl sgiehl merged commit 56640ae into matomo-org:4.x-dev May 3, 2022
@sgiehl sgiehl removed Needs Review PRs that need a code review Stale The label used by the Close Stale Issues action labels May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants