Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] add polyfill for String.replaceAll #19110

Merged
merged 1 commit into from Apr 18, 2022

Conversation

diosmosis
Copy link
Member

Description:

Fixes #19109. Adding the polyfill adds ~0.3K to gzipped assets. Alternatively we could just remove the use and maybe in UI tests add a String.prototype.replaceAll function that displays an error on screen to catch other uses. Adding the polyfill was the simpler fix.

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label Apr 15, 2022
@diosmosis diosmosis added this to the 4.9.1 milestone Apr 15, 2022
@justinvelluppillai justinvelluppillai merged commit fc5dfe6 into next_release Apr 18, 2022
@justinvelluppillai justinvelluppillai deleted the vue-replace-all-polyfill branch April 18, 2022 21:46
@justinvelluppillai justinvelluppillai added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels Apr 18, 2022
@justinvelluppillai justinvelluppillai linked an issue Apr 26, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard broken by 4.9.0 browser incompatibility
2 participants