Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform adblock test after page has finished loading, not immediately. #19106

Merged
merged 1 commit into from Apr 18, 2022
Merged

Perform adblock test after page has finished loading, not immediately. #19106

merged 1 commit into from Apr 18, 2022

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Apr 14, 2022 •
edited

Description:

As title. Required since some code is now loaded w/ defer.

Review

@diosmosis diosmosis changed the base branch from 4.x-dev to next_release April 14, 2022 15:17
@diosmosis diosmosis mentioned this pull request Apr 14, 2022
Closed
@sgiehl sgiehl added this to the 4.9.1 milestone Apr 14, 2022
@sgiehl sgiehl added Waiting for user feedback Indicates the Matomo team is waiting for feedback from the author or other users. and removed Waiting for user feedback Indicates the Matomo team is waiting for feedback from the author or other users. labels Apr 14, 2022
@sgiehl
Copy link
Member

sgiehl commented Apr 14, 2022

Fix was confirmed by a user in #19097

@diosmosis diosmosis added the Needs Review PRs that need a code review label Apr 14, 2022
@Findus23 Findus23 linked an issue Apr 16, 2022 that may be closed by this pull request
New bold red message about ad blockers at the top of each page #19097
Closed
@MatomoForumNotifications
Copy link

This pull request has been mentioned on Matomo forums. There might be relevant details there:

https://forum.matomo.org/t/fur-den-fall-dass-sie-einen-ad-blocker-verwenden-deaktivieren-sie-diesen-bitte-fur-diese-seite-um-sicherzustellen-dass-matomo-problemlos-lauft/45558/2

@justinvelluppillai justinvelluppillai merged commit 40ed028 into next_release Apr 18, 2022
@justinvelluppillai justinvelluppillai deleted the vue-ad-block-detect branch April 18, 2022 21:53
@justinvelluppillai justinvelluppillai removed the Needs Review PRs that need a code review label Apr 18, 2022
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvelluppillai justinvelluppillai justinvelluppillai approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.9.1
Development

Successfully merging this pull request may close these issues.

New bold red message about ad blockers at the top of each page
4 participants
@diosmosis @sgiehl @MatomoForumNotifications @justinvelluppillai