Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure required translations are loaded for Goal management #19102

Merged
merged 1 commit into from Apr 14, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 14, 2022

Description:

As reported on the forum (https://forum.matomo.org/t/the-string-general-description-was-not-loaded-in-javascript/45513) it might happen that a translation string is not available in javascript. This ist most likely the case as all other plugins that might already load it are disabled.

Review

@sgiehl sgiehl added the Needs Review PRs that need a code review label Apr 14, 2022
@sgiehl sgiehl added this to the 4.9.1 milestone Apr 14, 2022
@justinvelluppillai justinvelluppillai merged commit 642951e into next_release Apr 14, 2022
@justinvelluppillai justinvelluppillai deleted the goaltranslationsjs branch April 14, 2022 21:33
@heurteph-ei
Copy link

Just for tracking, another strange behavior about this translations issue...
https://forum.matomo.org/t/plugin-goals-error-after-update-4-9-0/45519

@justinvelluppillai justinvelluppillai removed the Needs Review PRs that need a code review label May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants