@peterhashair
Description:
Fixes: #19081
Force matomo.org marketplace and plugin using SSL as default.
Review
- [ ] Functional review done
- [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- [ ] Security review done
- [ ] Wording review done
- [ ] Code review done
- [ ] Tests were added if useful/possible
- [ ] Reviewed for breaking changes
- [ ] Developer changelog updated if needed
- [ ] Documentation added if needed
- [ ] Existing documentation updated if needed
@Findus23 that's a draft PR, not for ready review yet, but good feedback, and direction hints, will keep updating. 😀
@justinvelluppillai I just did some scan on this one, I found allowed_outgoing_protocols in this config, if we remove http, that will force all the requests to HTTPS as default, no additional code is needed.
@justinvelluppillai
Hi @peterhashair that would make http requests fail, it wouldn't force them to be https. Also it wouldn't allow us the gradual approach of informing users as described in the issue you're working on. I think stick to the plan, change the plugins and marketplace API URLs to https, add an option to force them to use http, etc.
Let me know if anything is unclear and we can discuss in a call also
@justinvelluppillai sounds good, I will update shortly
@justinvelluppillai that makes sense, I will discuss it with @bx80 in the next session.
Sounds good. I will remove Needs Review label meantime.