Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[security] Force matomo.org related requests to use ssl as default #19098

Merged
merged 47 commits into from May 17, 2022
Merged

[security] Force matomo.org related requests to use ssl as default #19098

merged 47 commits into from May 17, 2022

Conversation

peterhashair
Copy link
Contributor

@peterhashair peterhashair commented Apr 14, 2022 •
edited

Description:

Fixes: #19081
Force matomo.org marketplace and plugin using SSL as default.

Review

Peter and others added 18 commits February 4, 2022 14:34
Update dataTable.js
c57dfac 
update database table
Merge branch '4.x-dev' into 18699-expand-bug
0ce7662
Merge branch '4.x-dev' into 18699-expand-bug
c0c7af1
Update dataTable.js
af8e2d2 
update table bug
Update dataTable.js
4df966d 
shorter the query
update screenshot
c11aec8 
update screenshot
@sgiehl
Merge branch '4.x-dev' into 18699-expand-bug
9b1e432
Update dataTable.js
1a72e1d 
make table size stable
@sgiehl
Merge branch '4.x-dev' into 18699-expand-bug
7f9bc33
Revert "Update dataTable.js"
43b5a82 
This reverts commit 1a72e1d.
Merge branch '4.x-dev' into 18699-expand-bug
e4ca99f
Update dataTable.js
3d055fc 
update columns
Revert "update screenshot"
35452ce 
This reverts commit c11aec8.
@sgiehl
Merge branch '4.x-dev' into 18699-expand-bug
b20c509
force ssl to api and plug
21cfd24 
force ssl to api and plug
force request to ssl
622bb10 
force request to ssl
Update Http.php
f0739c5 
update tests
update tests
be0a038 
update condition only on matomo.org
Findus23
Findus23 reviewed Apr 14, 2022
View reviewed changes
config/global.ini.php Outdated Show resolved Hide resolved
Findus23
Findus23 reviewed Apr 14, 2022
View reviewed changes
core/Http.php Outdated Show resolved Hide resolved
@peterhashair
Copy link
Contributor Author

@Findus23 that's a draft PR, not for ready review yet, but good feedback, and direction hints, will keep updating. 😀

Peter added 3 commits April 19, 2022 13:22
update checks
af620b6 
update checks
update default to https
9936a34 
update default to https
update phpcs check
b3d11f0 
update phpcs check
@peterhashair peterhashair changed the title [security] Force all the request to ssl [security] Force matomo.org related requests to use ssl as default Apr 19, 2022
Peter added 3 commits May 10, 2022 13:36
remove double diagnostic
3b640f5 
remove double diagnostic
force api using https
77c8f7f 
force api using https
update tests
9c22be2 
update tests
@peterhashair peterhashair requested a review from bx80 May 10, 2022 04:28
@peterhashair peterhashair added the Needs Review PRs that need a code review label May 10, 2022
update feed back
1395c94 
update feed back
bx80
bx80 reviewed May 12, 2022
View reviewed changes
core/Http.php Outdated Show resolved Hide resolved
update failed display message
8daf002 
update failed display message
@justinvelluppillai
Update plugins/CoreUpdater/Diagnostic/HttpsUpdateCheck.php
1f2a0c2 
Co-authored-by: Justin Velluppillai <justin@innocraft.com>
bx80
bx80 reviewed May 16, 2022
View reviewed changes
config/global.ini.php Outdated Show resolved Hide resolved
@justinvelluppillai justinvelluppillai removed the Needs Review PRs that need a code review label May 17, 2022
Peter added 7 commits May 17, 2022 14:44
update hardcode to translation
95c61ac 
update hardcode to translation
update translation
6a42f15 
update translation
update language and some logic
d16af3f 
update language and some logic
Merge branch '4.x-dev' into m19081
cdad079
run test
5119723 
run test
trigger test
cc3fdf5 
trigger test
update screenshot
fc708fe 
update screenshot
@bx80 bx80 added this to the 4.11.0 milestone May 17, 2022
@bx80 bx80 merged commit 35957fc into 4.x-dev May 17, 2022
@bx80 bx80 deleted the m19081 branch May 17, 2022 22:12
@bx80 bx80 mentioned this pull request Jul 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvelluppillai justinvelluppillai justinvelluppillai requested changes

@Findus23 Findus23 Findus23 left review comments

@bx80 bx80 bx80 approved these changes

Assignees

@peterhashair peterhashair

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.11.0
5 participants
@peterhashair @justinvelluppillai @Findus23 @bx80 @sgiehl