@peterhashair opened this Pull Request on April 14th 2022 Contributor

Description:

Fixes: #19081
Force matomo.org marketplace and plugin using SSL as default.

Review

@peterhashair commented on April 18th 2022 Contributor

@Findus23 that's a draft PR, not for ready review yet, but good feedback, and direction hints, will keep updating. 😀

@peterhashair commented on April 27th 2022 Contributor

@justinvelluppillai I just did some scan on this one, I found allowed_outgoing_protocols in this config, if we remove http, that will force all the requests to HTTPS as default, no additional code is needed.

@justinvelluppillai commented on April 27th 2022 Contributor

Hi @peterhashair that would make http requests fail, it wouldn't force them to be https. Also it wouldn't allow us the gradual approach of informing users as described in the issue you're working on. I think stick to the plan, change the plugins and marketplace API URLs to https, add an option to force them to use http, etc.

Let me know if anything is unclear and we can discuss in a call also

@peterhashair commented on April 27th 2022 Contributor

@justinvelluppillai sounds good, I will update shortly

@peterhashair commented on May 6th 2022 Contributor

@justinvelluppillai that makes sense, I will discuss it with @bx80 in the next session.

@justinvelluppillai commented on May 6th 2022 Contributor

Sounds good. I will remove Needs Review label meantime.

This Pull Request was closed on May 17th 2022
Powered by GitHub Issue Mirror