New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New bold red message about ad blockers at the top of each page #19097
Comments
This warning already existed for a long time with no changes in Matomo 4.9.0. |
@CyrilBrulebois You should check if your browser blocks any requests to Matomo. That message is automatically hidden by CSS/JS. If it's visible that means the requests failed. |
@sgiehl Thanks, I had been checking this since the previous reply: I'm indeed seeing an item getting blocked ( I'm not sure why that's happening all of a sudden then. Since you folks seem to consider this is not a bug, I suppose I'll patch out the twig include in my installation, and call it a day. |
For me the message definitely appears only since the update to Matomo 4.9.0. |
That's interesting. The code of that template hadn't changed since 2018. Wondering why it should suddenly start blocking it, unless there was an update in the adblocker maybe. |
I was trying to check https://github.com/easylist/easylist's history (that's the trigger according to uBlock Origins), but got tired of waiting for deltas to be resolved on that ~ 3G repository… Sure, disabling the adblocker for Matomo might work as a general solution might work. I don't understand why I would have to do that. Going back in the twig file's history, I'm seeing #12493 mentioned. It seems the intent was use within the installer. I'm on the front page of my instance. Why should I turn my adblocker off? |
While disabling the easylist filter in Adblock Plus works for me I want to note that I did the Matomo update ~ 1 hour ago. The last filter list update was done a few hours earlier on my system. It would also have been a very big coincidence if the filter list would have been updated in exactly the same moment as Matomo. |
@CyrilBrulebois #12493 was not just intended for the installer, but also all other pages in Matomo. And this check has been there indeed since 2018. Everyone, do you by chance have your Matomo instance installed on a subdomain called matomo.yoursite.example? easylist/easylist@ece9fd8#commitcomment-56844920 [Update: No, it seems like this is another unrelated issue] |
In my case it's analytics.yoursite.example. And the linked change was commited in September 2021, so it would not explain why it suddenly happens after the Matomo 4.9.0 update. |
That's of course fully true (and I assume most Matomo users use ad-blockers). That said, maybe the check could be improved. At the moment it seems to check if a |
@cadeyrn That's true, that is probably unrelated. I think I can reproduce this issue now that I added an exception rule ( |
I'm using |
The easylist update seems like a red herring too, finally retried a
|
@Findus23 I'm not able to reproduce that with my installed adblocker. If you find a way to fix / improve that feel free to create a PR against |
The timing issue hypothesis (or something similar) seems possible to my rather inexperienced web debugger eyes: once the demo page is loaded, using Firefox's debugger to run parts of the detection function correctly gets |
@CyrilBrulebois this looks like it's related to the Vue migration as some code is no longer loaded in a blocking manner. Can you check if this change fixes the issue for you: #19106 ? |
@diosmosis Sure thing: wrapping the code inside that (Tested by hitting Refresh a few times with that change applied, all good; undoing the change makes the issue come back immediately.) |
I just joined, to report that I am seeing this horrible message about the adblocker. Obviously I am not going to disable my ad blocker for anyone :D Is there a manual way to remove it entirely? Thank you. |
@LauraTaylorUK you can apply the changes from this PR: https://github.com/matomo-org/matomo/pull/19106/files |
Thank you for the prompt fix and support. Maybe now is a good time to ask, why there is a adblock detection script included in the admin interface? |
Mainly for the reason I explained here: #19097 (comment) There are too many ill-configured ad-blockers and overly broad blocking rules that break Matomo and when it does it often does in ways that makes Matomo look broken. And the adblocker is often not the first thing people think of when debugging. |
This issue has been mentioned on Matomo forums. There might be relevant details there: |
Since upgrading to 4.9.0, a big fat red message appears at the top of each page, warning me against the use of ad blockers:
Screenshot:
Expected Behavior
Back to pre-4.9.0 behaviour: no such messages.
Current Behavior
The message hideous and non-dismissable. Whether I'm using an ad blocker is absolutely none of Matomo's business.
Context
Happily upgraded from the previous release to 4.9.0, and wow! Quite a change from the usually seamless upgrade path!
Your Environment
The text was updated successfully, but these errors were encountered: