Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correctly handle string 0/1 values for useAnonymizedIpForVisitEnrichment #19094

Merged
merged 1 commit into from Apr 14, 2022
Merged

correctly handle string 0/1 values for useAnonymizedIpForVisitEnrichment #19094

merged 1 commit into from Apr 14, 2022

Conversation

diosmosis
Copy link
Member

Description:

Also handle string values in FieldCheckbox just in case it happens at some point.

Fixes #19089

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label Apr 13, 2022
@diosmosis diosmosis added this to the 4.9.1 milestone Apr 13, 2022
@justinvelluppillai justinvelluppillai changed the base branch from 4.x-dev to next_release April 13, 2022 21:02
peterhashair
peterhashair approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me, the failed tests seems unrelated.

@sgiehl
Copy link
Member

sgiehl commented Apr 14, 2022

@peterhashair didn't you see that the base branch has been changed and the PR now contains a lot commits that shouldn't be included? You shouldn't simply approve such stuff, without leaving a note, as it could happen that someone simply merges afterwards without having a look again.

@diosmosis @sgiehl
correctly handle string 0/1 values for useAnonymizedIpForVisitEnrichm…
7e23769 
…ent value which comes from config & handle string values in FieldCheckbox
@sgiehl sgiehl merged commit 67e536e into next_release Apr 14, 2022
@sgiehl sgiehl deleted the vue-use-anonymized-ip branch April 14, 2022 12:21
@sgiehl sgiehl removed the Needs Review PRs that need a code review label Apr 14, 2022
@peterhashair
Copy link
Contributor

@sgiehl sorry, I saw lots of old commits, but I thought that was on purpose, will keep an eye thought from now on.

@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhashair peterhashair peterhashair approved these changes

@sgiehl sgiehl Awaiting requested review from sgiehl

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.9.1
Development

Successfully merging this pull request may close these issues.

Cannot save setting "Also use the Anonymized IP addresses when enriching visits."
4 participants
@diosmosis @sgiehl @peterhashair @justinvelluppillai