@sgiehl opened this Pull Request on April 12th 2022 Member

Description:

As discussed in #17033, it's actually not expected that the country might be automatically guessed if the provider plugin is active, but the chosen location provider does not serve a result.

This PR kind of replaces #17033. The last thing that would be missing or could be improved is to add a check if the provided IP might already have been anonymized. Otherwise IPs like 123.123.0.0 might get passed to gethostbyaddr, which can't have a result, so we could prevent that. But that might be not that much important right now.

Review

@sgiehl commented on April 13th 2022 Member

@bx80 seems the mockbuilder can't handle private methods in newer php 8 versions. Also found another small issue, why it didn't work correctly. Should be fixed now.

This Pull Request was closed on April 14th 2022
Powered by GitHub Issue Mirror