Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bottom clicker is behaving incorrectly for the Event Categories modal display #19080

Open
atom-box opened this issue Apr 11, 2022 · 3 comments
Open

Bottom clicker is behaving incorrectly for the Event Categories modal display #19080

atom-box opened this issue Apr 11, 2022 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall.
Milestone
For Prioritization

Comments

@atom-box
Copy link

Expected Behavior

When you click the bottom of the Event Categories modal, the widget should give correct words and numbers

Current Behavior

The modal does not show the correct words or data, especially in response to clicking the bottom link

Steps to Reproduce (for Bugs)

  1. Go to the user interface:
    Behavior > Events > Event Categories
  2. Try clicking the bottom of the modal a few times and note the results

You can see it on the demo site:
https://demo.matomo.cloud/index.php?module=CoreHome&action=index&idSite=1&period=day&date=yesterday#?idSite=1&period=day&date=yesterday&category=General_Actions&subcategory=Events_Events
@atom-box atom-box added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Apr 11, 2022
@Starker3
Copy link
Contributor

To provide more context on this bug, when clicking the highlighted text:
image
We expect the report to be updated, but at present only the text at the top of the report and the link at the bottom changes:
image

It doesn't actually switch to the correct report:
image

@sgiehl
Copy link
Member

sgiehl commented Apr 12, 2022

@atom-box @Starker3 While the report title should maybe not be updated, that feature still behaves like it should. The secondary dimension is changed. That means the subtables are others.

@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Apr 12, 2022
@sgiehl
Copy link
Member

sgiehl commented Apr 12, 2022

Note: Changing the secondary dimension is handled the same as a related report. And that currently always updates the title of the report. See

matomo/plugins/CoreHome/javascripts/dataTable.js

Lines 1718 to 1747 in 7c80d54

relatedReports.each(function () {
var clicked = this;
$(this).unbind('click').click(function (e) {
var $this = $(this);
var url = $this.attr('href');
// modify parameters
self.resetAllFilters();
var newParams = broadcast.getValuesFromUrl(url);
for (var key in newParams) {
self.param[key] = decodeURIComponent(newParams[key]);
}
delete self.param.pivotBy;
delete self.param.pivotByColumn;
var relatedReportName = $this.text();
// do ajax request
self.reloadAjaxDataTable(true, (function (relatedReportName) {
return function (newReport) {
var newDomElem = self.dataTableLoaded(newReport, self.workingDivId);
hideShowRelatedReports(clicked);
replaceReportTitleAndHelp(newDomElem, relatedReportName);
}
})(relatedReportName));
});
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall.
Projects
None yet
Milestone
For Prioritization
Development

No branches or pull requests
4 participants
@sgiehl @Starker3 @atom-box @innocraft-automation