Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide visitor id in visits log if profile is disabled #19078

Merged
merged 1 commit into from Apr 12, 2022
Merged

Hide visitor id in visits log if profile is disabled #19078

merged 1 commit into from Apr 12, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 11, 2022

Description:

refs #18884

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Apr 11, 2022
@sgiehl sgiehl added this to the 4.10.0 milestone Apr 11, 2022
bx80
bx80 approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. I've checked that the visitor ID is hidden from the visit log tooltip when the visitor profile is disabled and shows normally otherwise. Code changes are straightforward and all look good to me.

@sgiehl sgiehl merged commit 341265b into 4.x-dev Apr 12, 2022
@sgiehl sgiehl deleted the m18884 branch April 12, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bx80 bx80 bx80 approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @bx80