Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Widgetize page translatable #19076

Closed
sgiehl opened this issue Apr 11, 2022 · 0 comments · Fixed by #19157
Closed

Make Widgetize page translatable #19076

sgiehl opened this issue Apr 11, 2022 · 0 comments · Fixed by #19157
Labels
c: i18n For issues around internationalisation and localisation. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
4.10.0

Comments

@sgiehl
Copy link
Member

sgiehl commented Apr 11, 2022

The Widgetize page is currently hard coded in english: https://demo.matomo.cloud/index.php?module=Widgetize&action=index&idSite=1&period=day&date=yesterday

We should move all the English strings into translation files.

Related files:

follow-up to #19029
@sgiehl sgiehl added c: i18n For issues around internationalisation and localisation. Needs priority decision This issue may need to be added to the current milestone by Product Manager labels Apr 11, 2022
@justinvelluppillai justinvelluppillai removed the Needs priority decision This issue may need to be added to the current milestone by Product Manager label Apr 12, 2022
@justinvelluppillai justinvelluppillai added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Apr 12, 2022
@korve korve mentioned this issue Apr 28, 2022
Merged
11 tasks
@sgiehl sgiehl linked a pull request Apr 29, 2022 that will close this issue
Make Widgetize page translatable #19157
Merged
11 tasks
sgiehl pushed a commit that referenced this issue May 2, 2022
@korve
Make Widgetize page translatable (#19157)
bd83a44 
* Refactored Widgetize Plugin: Make Widgetize page translatable (#19076)

* style: add spaces to closing tags

* refactor: implement CR changes

* refactor: update getClientSideTranslationKeys

* add missing spread operator to linkTo method
@sgiehl sgiehl modified the milestones: Backlog (Help wanted), 4.10.0 May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: i18n For issues around internationalisation and localisation. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
4.10.0
Development

Successfully merging a pull request may close this issue.

Make Widgetize page translatable
2 participants
@justinvelluppillai @sgiehl