Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] add piwik-api.js error handling logic to AjaxHelper.fetch if createErrorNotification is set to false… #19071

Merged
merged 3 commits into from Apr 11, 2022
Merged

[Vue] add piwik-api.js error handling logic to AjaxHelper.fetch if createErrorNotification is set to false… #19071

merged 3 commits into from Apr 11, 2022

Conversation

diosmosis
Copy link
Member

Description:

… and do not call AjaxHelper errorCallback in this case too.

Review

@diosmosis
add piwik-api.js error handling logic to AjaxHelper.fetch if createEr…
2734a65 
…rorNotification is set to false and do not call AjaxHelper errorCallback in this case too
@diosmosis diosmosis added the Needs Review PRs that need a code review label Apr 8, 2022
@diosmosis diosmosis added this to the 4.10.0 milestone Apr 8, 2022
@diosmosis diosmosis mentioned this pull request Apr 8, 2022
Merged
11 tasks
@sgiehl
Copy link
Member

sgiehl commented Apr 11, 2022

I guess the submodule update should be reverted before merging

@sgiehl sgiehl removed the Needs Review PRs that need a code review label Apr 11, 2022
@diosmosis
Copy link
Member Author

Merging. (Note: there's a seemingly unrelated customalerts UI test failure that will hopefully be fixed by matomo-org/plugin-CustomAlerts#116.)

@diosmosis diosmosis merged commit 5d8f340 into 4.x-dev Apr 11, 2022
@diosmosis diosmosis deleted the vue-skip-error-callback branch April 11, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhashair peterhashair peterhashair approved these changes

@sgiehl sgiehl Awaiting requested review from sgiehl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @sgiehl @peterhashair