Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds update script to remove broken scheduled reports from db #19062

Merged
merged 2 commits into from Apr 12, 2022
Merged

Adds update script to remove broken scheduled reports from db #19062

merged 2 commits into from Apr 12, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 7, 2022

Description:

In a former version of Matomo scheduled reports were stored in a broken state. Instead of the json_encoded data, the string Array was stored in the database. As those reports can't be used nor restored it should be better to simply remove them.

fixes #19047

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Apr 7, 2022
@sgiehl sgiehl added this to the 4.10.0 milestone Apr 7, 2022
bx80
bx80 reviewed Apr 11, 2022
View reviewed changes
core/Updates/4.10.0-b1.php Outdated Show resolved Hide resolved
bx80
bx80 approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by updating some local db report table rows with the value 'Array' in the reports and parameters columns, then ran the update to confirm they are removed 👍

@sgiehl @bx80
Update core/Updates/4.10.0-b1.php
ce4ad5f 
Co-authored-by: Ben Burgess <88810029+bx80@users.noreply.github.com>
@sgiehl sgiehl merged commit c45534a into 4.x-dev Apr 12, 2022
@sgiehl sgiehl deleted the m19047 branch April 12, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bx80 bx80 bx80 approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.10.0
Development

Successfully merging this pull request may close these issues.

Scheduler Error Missing parameter displayFormat
2 participants
@sgiehl @bx80