Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent possible errors when exporting datasets in GDPR tool #19056

Merged
merged 2 commits into from Apr 12, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 5, 2022

Description:

When exporting datasets in the GDPR tool we try to format all columns that are exported.
This is done by checking for matching dimensions. In some cases this causes problems, as the dimensions actually don't have a format method that can format the raw column value (as they define a sql segment that should be applied).

This currently happens e.g. when exporting a dataset that contains some media actions, as the Hour dimension is used for server_time column.

This PR drops using dimensions for formatting if they define a special sql segment.
In addition it catches possible exceptions thrown while formatting and using the unformatted raw value instead. Possible exceptions will be logged so we still might notice possible problems.

Review

@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review labels Apr 5, 2022
@sgiehl sgiehl added this to the 4.10.0 milestone Apr 5, 2022
@justinvelluppillai justinvelluppillai merged commit b24d41f into 4.x-dev Apr 12, 2022
@justinvelluppillai justinvelluppillai deleted the fixgdprexport branch April 12, 2022 08:52
@justinvelluppillai justinvelluppillai removed the Needs Review PRs that need a code review label Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants