Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] migrate widgetize plugin to vue #19029

Merged
merged 6 commits into from Apr 11, 2022
Merged

[Vue] migrate widgetize plugin to vue #19029

merged 6 commits into from Apr 11, 2022

Conversation

diosmosis
Copy link
Member

Description:

Changes:

  • Migrate widget-preview directive to Vue component.
  • Migrate export-widget controller to Vue component.

Review

@diosmosis diosmosis added this to the 4.9.0 milestone Mar 30, 2022
@diosmosis diosmosis marked this pull request as draft March 30, 2022 23:44
@diosmosis diosmosis added the Needs Review PRs that need a code review label Apr 6, 2022
@diosmosis diosmosis marked this pull request as ready for review April 6, 2022 22:21
@sgiehl sgiehl removed the Needs Review PRs that need a code review label Apr 11, 2022
@sgiehl sgiehl merged commit 793c7db into 4.x-dev Apr 11, 2022
@sgiehl sgiehl deleted the vue-widgetize branch April 11, 2022 09:39
@sgiehl sgiehl mentioned this pull request Apr 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

@peterhashair peterhashair Awaiting requested review from peterhashair

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @sgiehl