@Starker3 opened this Issue on March 29th 2022 Contributor

In #18279 an option was added to disable archiving for segments and the option also allows it to be disabled for specific Site IDs the same way that it works for tracker settings (Eg. [General_{siteId}])

It would be quite useful if this also worked for some other [General] config settings as well, specifically like the datatable_archiving_maximum_rows settings listed in this FAQ: https://matomo.org/faq/how-to/faq_54/

For users that have a lot of sites on one instance or even with a few sites where some might be high traffic, it would enable users to have site specific row limits without needing to change the setting for all sites on that instance.

@sgiehl commented on March 30th 2022 Member

Just a general note on the effort that is needed to make that possible:
In almost all cases we are currently using Config::getInstance()->General['someconfig'] to access config values.
With #18279 we introduced the class GeneralConfig, which automatically tries to use a site specific config if available.
So it's basically "only" replacing Config::getInstance()->General['someconfig'], with GeneralConfig::getConfigValue('someconfig', $idSite). But this will actually only work smoothless in places where the siteid is already available or can be easily fetched.

Powered by GitHub Issue Mirror