@diosmosis opened this Pull Request on March 28th 2022 Member

Description:

Changes:

  • Migrated scheduled reports management from twig/angularjs to vue.
  • Migrated MobileMessaging extension to ScheduledReports to Vue.
  • Add redirectOnSuccess option to AjaxHelper.
  • Recognize vue-entry-ignore attribute in compileVueEntryComponents() to avoid mounting vue components even if they have vue-entry.
  • Add extraProps to compileVueEntryComponents() to pass extra property values to each vue-entry.

Review

@diosmosis commented on April 4th 2022 Member

Converting to draft for a bit, might be possible to provide full BC.

@sgiehl commented on April 7th 2022 Member

@diosmosis just found one last regression on this one. If the description of the report contains a special char like < or " it will be displayed encoded. Guess the "problem" is that the title is already stored encoded in the database. Before it was using rawSafeDecoded in twig. Not sure if we already have something similar in vue to use.

@diosmosis commented on April 7th 2022 Member

@sgiehl :+1: we'd just decode it client side. Vue just sets textContent/innerText so its safe (unless using v-html which uses innerHTML).

This Pull Request was closed on April 8th 2022
Powered by GitHub Issue Mirror