Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sarawak and Terengganu on Visitors Interactive Map Widget #19006

Closed
avimaymon opened this issue Mar 27, 2022 · 1 comment · Fixed by #19007
Closed

Fix Sarawak and Terengganu on Visitors Interactive Map Widget #19006

avimaymon opened this issue Mar 27, 2022 · 1 comment · Fixed by #19007
Assignees
@sgiehl
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
4.9.0

Comments

@avimaymon
Copy link

avimaymon commented Mar 27, 2022 •
edited

Expected Behavior

  1. When clicking on Sarawak we should get the data for Sarawak, when clicking on Terengganu we should get the data for Terengganu.
  2. The tooltip should be available also after going into a state and going back out.

Current Behavior

  1. Clicking on Sarawak shows data for Terengganu, clicking on Terengganu shows data for Sarawak.
  2. Before going into a state we have the tooltip, after going inside of it and coming back out it's not available anymore
    Both issues can be seen here
    https://ibb.co/5LWJnGB

Steps to Reproduce (for Bugs)

Can be seen in this GIF
https://ibb.co/5LWJnGB

Your Environment

  • Browser: Microsoft Edge
  • Operating System: Windows 10

The other details will be added shortly

  • Matomo Version:
  • PHP Version:
  • Server Operating System:
  • Additionally installed plugins:
@avimaymon avimaymon added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Mar 27, 2022
@sgiehl
Copy link
Member

sgiehl commented Mar 27, 2022

Hi @avimaymon
Thanks for the report. Seems the ISO codes on our map are flipped in that case. I'll prepare a PR to fix that.

@sgiehl sgiehl added this to the 4.9.0 milestone Mar 27, 2022
@sgiehl sgiehl self-assigned this Mar 27, 2022
@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Mar 27, 2022
@sgiehl sgiehl mentioned this issue Mar 27, 2022
Merged
11 tasks
@justinvelluppillai justinvelluppillai changed the title Visitors Interactive Map Widget - Sarawak and Terengganu are switched + no tooltip after going in and out Fix Sarawak and Terengganu on Visitors Interactive Map Widget Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
4.9.0
Development

Successfully merging a pull request may close this issue.

Fix Malaysian ISO codes on map matomo-org/matomo
2 participants
@sgiehl @avimaymon