@diosmosis opened this Pull Request on March 27th 2022 Member

Description:

Changes:

  • Migrate transition-exporter to Vue.
  • Migrate transition-switcher to Vue.

Review

@peterhashair commented on April 4th 2022 Contributor

It seems like when you refresh the page, it loads a warning, but 4.x-dev doesn't have that warning.

https://user-images.githubusercontent.com/3783072/161456442-537f8a28-106a-436a-ba4c-ad058f2de24b.mp4

@diosmosis commented on April 4th 2022 Member

@peterhashair should be fixed w/ last commit

@sgiehl commented on April 4th 2022 Member

@peterhashair @diosmosis it would be good to always merge in the latest changes from 4.x-dev and check if all tests are passing before merging a PR. That way you would have noticed this failure:

1) Piwik\Tests\Integration\ReleaseCheckListTest::test_noVueHtmlWithoutSanitize
Found uses of v-html without $sanitize:
- /home/travis/build/matomo-org/matomo/plugins/Transitions/vue/src/TransitionSwitcher/TransitionSwitcher.vue
Failed asserting that a string is empty.
/home/travis/build/matomo-org/matomo/tests/PHPUnit/Integration/ReleaseCheckListTest.php:721
This Pull Request was closed on April 4th 2022
Powered by GitHub Issue Mirror