Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] migrate opt-out-customizer to Vue #19003

Merged
merged 8 commits into from Apr 11, 2022
Merged

[Vue] migrate opt-out-customizer to Vue #19003

merged 8 commits into from Apr 11, 2022

Conversation

diosmosis
Copy link
Member

Description:

Changes:

  • Migrate piwik-opt-out-customizer directive to Vue.

Review

@diosmosis diosmosis added this to the 4.9.0 milestone Mar 26, 2022
@diosmosis diosmosis marked this pull request as draft March 26, 2022 21:42
@diosmosis diosmosis marked this pull request as ready for review April 2, 2022 20:00
@diosmosis diosmosis added the Needs Review PRs that need a code review label Apr 2, 2022
@sgiehl sgiehl modified the milestones: 4.9.0, 4.10.0 Apr 4, 2022
sgiehl
sgiehl approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only found a left over todo. Will remove it myself. Otherwise this looks good to merge

plugins/PrivacyManager/vue/src/OptOutCustomizer/OptOutCustomizer.vue Outdated Show resolved Hide resolved
@sgiehl sgiehl removed the Needs Review PRs that need a code review label Apr 11, 2022
@sgiehl sgiehl merged commit 5531607 into 4.x-dev Apr 11, 2022
@sgiehl sgiehl deleted the vue-opt-out-customizer branch April 11, 2022 14:57
@diosmosis
Copy link
Member Author

Thanks for removing the TODO!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

@peterhashair peterhashair Awaiting requested review from peterhashair

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @sgiehl