Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sailfish also to UserAgentParser. #190

Closed
wants to merge 1 commit into from

Conversation

dawnbreak
Copy link
Contributor

Add SailfishBrowser and Sailfish OS to UserAgentParser.
Moved Sailfish OS to 'Other Mobile' OS family in UserAgentParserEnhanced.

Add SailfishBrowser and Sailfish OS to UserAgentParser.
Moved Sailfish OS to 'Other Mobile' OS family in UserAgentParserEnhanced.
@halfdan
Copy link
Member

halfdan commented Jan 14, 2014

Any specific reason to move it to "Other Mobile"?

@dawnbreak
Copy link
Contributor Author

Well, the whole OS family stuff is quite messy I think. There is also already quite a gap between UserAgentParser and UserAgentParserEnhanced. Is there a reason there are two libs for this? I thought it would fit better to 'Other Mobile' than a new Sailfish OS family as in my first pull request where I add Jolla to UserAgentParserEnhanced.
As far as I understand the family conditions Sailfish OS runs on something they call Nemo, which is based on Mer, which is based on MeeGo, wich is based on Maemo(Debian) and Moblin(RedHat) which is all Linux. Tizen is also based on Meego and Tizen is in 'Other Mobile' already, but only in UserAgentParserEnhanced.
Just saw MeeGo is in the Symbian OS family in UserAgentParserEnhanced, which I think is wrong and should also be in 'Other Mobile' like in UserAgentParser, or even another new OS family Meego or Maeomo/Moblin with Tizen, MeeGo, Sailfish, etc.?

@mattab
Copy link
Member

mattab commented Jan 15, 2014

we want to only improve UserAgentParserEnhanced going forward.

We plan to merge DevicesDetection and UserSettings repors, see: http://dev.piwik.org/trac/ticket/3962#ticket

technically the UserAgentParser is deprecated. You can help improve the UserAgentParserEnhanced library! Thanks

@mattab mattab closed this Jan 15, 2014
@dawnbreak
Copy link
Contributor Author

"View Visitor Profile" in Live View still needs the name mappings from UserAgentParser.
Will take a closer look on the os families in UserAgentParserEnhanced the next days.

@mattab
Copy link
Member

mattab commented Jan 16, 2014

It would be great if you can help us deprecate UserAgentParser 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants