Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate AnonymizeIpController to VueJS #18975

Merged
merged 7 commits into from Mar 26, 2022
Merged

Migrate AnonymizeIpController to VueJS #18975

merged 7 commits into from Mar 26, 2022

Conversation

diosmosis
Copy link
Member

Description:

Changes:

  • migrate AnonymizeIpController to vue.

Review

@diosmosis diosmosis added this to the 4.9.0 milestone Mar 21, 2022
@diosmosis diosmosis marked this pull request as draft March 21, 2022 02:07
@diosmosis diosmosis marked this pull request as ready for review March 26, 2022 05:58
@diosmosis diosmosis added the Needs Review PRs that need a code review label Mar 26, 2022
sgiehl
sgiehl approved these changes Mar 26, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@sgiehl sgiehl merged commit b5b62fd into 4.x-dev Mar 26, 2022
@sgiehl sgiehl deleted the vue-anonymize-ip branch March 26, 2022 16:24
@sgiehl sgiehl removed the Needs Review PRs that need a code review label Mar 26, 2022
@justinvelluppillai justinvelluppillai changed the title [Vue] migrate AnonymizeIpController to vue Migrate AnonymizeIpController to VueJS Apr 11, 2022
@MatomoForumNotifications
Copy link

This pull request has been mentioned on Matomo forums. There might be relevant details there:

https://forum.matomo.org/t/anonymize-tracking-data-issue-after-update-to-4-9/45565/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

@peterhashair peterhashair Awaiting requested review from peterhashair

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @MatomoForumNotifications @sgiehl