@diosmosis opened this Pull Request on March 18th 2022 Member

Description:

This PR is based off of #18955.

Changes:

  • Migrate PiwikMarketplaceController & piwik-marketplace directive to vue component.
  • Migrate piwik-plugin-name directive to
  • Handle vue-directive HTML attribute to apply vue directive to vanilla HTML (ie, twig template output). Shouldn't be used in new code, mostly to use in twig code that may not get converted to Vue.
  • Remove use of $location in broadcast.updatePopoverParamValue.
  • Add types for dotdotdot library.

UI test failure appears to be unrelated.

Review

@diosmosis commented on March 23rd 2022 Member

@peterhashair I think this is a random race condition that happens in Materialize. It came up before but I couldn't find a fix for it. Can you check if it happens every time? Its all working for me locally.

@peterhashair commented on March 23rd 2022 Contributor

@diosmosis it happens on mine every time, but people claim there is a bug on materialize and VUE. here is the solution for that, hopefully, that helps https://stackoverflow.com/questions/33704122/vuejs-materializecss-select-field/43728599#43728599

@diosmosis commented on March 23rd 2022 Member

@peterhashair that link doesn't mention the tabIndex error, which has been present since before the vue migration. Can you tell me what browser you were using and any other information to help reproduce?

@peterhashair commented on March 23rd 2022 Contributor
@diosmosis commented on March 23rd 2022 Member

@sgiehl would you have time to try and reproduce the error @peterhashair is seeing? I'm still not able to reproduce it.

EDIT: ignore this was able to reproduce.

@diosmosis commented on March 23rd 2022 Member

@peterhashair can you try doing a ./console cache:clear and hard reload? That looked like it sent you to the main dashboard, instead of back to the marketplace.

EDIT: Wait, maybe that's the cause, I was trying from the admin page. Yes, I can reproduce it now. Thanks for uploading a video :+1:

@peterhashair commented on March 23rd 2022 Contributor
@diosmosis commented on March 23rd 2022 Member

@peterhashair should be fixed in latest commit

@diosmosis commented on March 23rd 2022 Member

@peterhashair can you take another look?

@peterhashair commented on March 23rd 2022 Contributor

@diosmosis when you do performance search a plugin, it redirects to the dashboard page. See screen record

https://user-images.githubusercontent.com/3783072/159815616-23de5809-1ebe-4b59-9447-00b717da0d1f.mp4

@diosmosis commented on March 24th 2022 Member

@peterhashair pushed a fix, hopefully the last one. Had to modify the Marketplace controller action to allow 'query' to be obtained from $_GET as well as $_POST, so the reporting page marketplace won't redirect to the admin page (cc @sgiehl).

@peterhashair commented on March 24th 2022 Contributor

@diosmosis there is another one sorry. When you click More button. It doesn't do the popup. see screenshot

https://user-images.githubusercontent.com/3783072/159834837-e6d3bfb6-7617-4b3e-be62-710f76ae2353.mp4

@diosmosis commented on March 25th 2022 Member

@peterhashair should be fixed in the latest push. Thanks for the thorough testing! :+1:

This Pull Request was closed on March 27th 2022
Powered by GitHub Issue Mirror