@AltamashShaikh opened this Pull Request on March 17th 2022 Contributor

Description:

Started renaming dimensions and segments starting with name Server time to Site Time/Time in UTC

Review

@sgiehl commented on March 22nd 2022 Member

@AltamashShaikh Is there a special reason why you renamed some of the segments?
Changing names of segments is a bit critical. Anyone using that segment might afterwards see errors as the segment gets invalid.

@AltamashShaikh commented on March 22nd 2022 Contributor

@AltamashShaikh Is there a special reason why you renamed some of the segments? Changing names of segments is a bit critical. Anyone using that segment might afterwards see errors as the segment gets invalid.

@sgiehl My bad, updating $nameSingular should be sufficient, I read the comments in tickets incorrectly and updated the segment too

@sgiehl commented on March 22nd 2022 Member

@AltamashShaikh no problem. Guess you can now also remove all the expected test files you had newly added.

This Pull Request was closed on March 24th 2022
Powered by GitHub Issue Mirror