Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] migrate PiwikMarketplaceLicenseController controller and twig template to Vue #18955

Merged
merged 8 commits into from Mar 21, 2022
Merged

[Vue] migrate PiwikMarketplaceLicenseController controller and twig template to Vue #18955

merged 8 commits into from Mar 21, 2022

Conversation

diosmosis
Copy link
Member

Description:

Changes:

  • Migrate PiwikMarketplaceLicenseController controller and twig template to vue.

Review

@diosmosis diosmosis added this to the 4.9.0 milestone Mar 17, 2022
@diosmosis diosmosis marked this pull request as draft March 17, 2022 01:32
@diosmosis diosmosis marked this pull request as ready for review March 17, 2022 03:00
@diosmosis diosmosis added the Needs Review PRs that need a code review label Mar 17, 2022
@sgiehl
Copy link
Member

sgiehl commented Mar 17, 2022

@diosmosis I locally tried to merge in the latest changes from 4.x-dev before testing. But that resulted in an error when opening the Marketplace:
image
Could you please check that?

sgiehl
sgiehl requested changes Mar 17, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By now I have only done some code review. Once the merge issue was fixed some local testing needs to be done.

plugins/Marketplace/templates/licenseform.twig
<a href="javascript:;" class="btn installAllPaidPlugins valign">
{{ 'Marketplace_InstallPurchasedPlugins'|translate }}
</a>
{% include '@Marketplace/paid-plugins-install-list.twig' %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That files doesn't seem to be removed. Is it still in use somewhere?

@diosmosis
Copy link
Member Author

@sgiehl fixed

@diosmosis diosmosis mentioned this pull request Mar 18, 2022
Merged
11 tasks
@sgiehl sgiehl merged commit bc5175b into 4.x-dev Mar 21, 2022
@sgiehl sgiehl deleted the vue-marketplace-license-key branch March 21, 2022 14:09
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

@peterhashair peterhashair Awaiting requested review from peterhashair

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @sgiehl @justinvelluppillai