@diosmosis opened this Pull Request on March 15th 2022 Member

Description:

Changes:

  • Migrate geoip2 updater directive to Vue.
  • Allow inline help in Field/FormField components to be specified via named slot instead of angularjs method of specifying jquery selector, and instead of vue method of using dynamic component (though that is still supported).

Review

@sgiehl commented on March 23rd 2022 Member

@diosmosis One thing doesn't seem to work correctly anymore.
If no geoip database is installed and you choose to configure manually and provide a URL for both databases and click the save button, the updater downloads the first database directly and the progress bar is displayed below. It takes a while for this to finish and then nothing happens. The last download request actually contains the next database that should be downloaded, but seems that isn't used. Once all downloads are finished I guess a notification should be shown or the page should be reloaded. This doesn't work with only one database either.

@diosmosis commented on March 23rd 2022 Member

@sgiehl should be fixed

@sgiehl commented on March 23rd 2022 Member

@diosmosis doing the manual setup now works without problems. But using the one click setup to automatically download the database now only shows the progress bar, the file name below isn't shown any longer.

@diosmosis commented on March 23rd 2022 Member

@sgiehl should also be fixed

@peterhashair commented on March 23rd 2022 Contributor

@diosmosis the VUE build failed, probably needs a re run

@diosmosis commented on March 23rd 2022 Member

@peterhashair I rebuild the files locally before committing.

This Pull Request was closed on March 24th 2022
Powered by GitHub Issue Mirror