Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Knowledge base discoverability improvements #18944

Merged
merged 10 commits into from Mar 17, 2022
Merged

Knowledge base discoverability improvements #18944

merged 10 commits into from Mar 17, 2022

Conversation

justinvelluppillai
Copy link
Contributor

@justinvelluppillai justinvelluppillai commented Mar 15, 2022 •
edited

Description:

Resolve #18934 - adds UI changes to make KB search more obvious; different KB help types more obvious; and adds links to relevant User guides for Goals and Ecommerce tracking.

Review

@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Mar 15, 2022
@justinvelluppillai justinvelluppillai mentioned this pull request Mar 16, 2022
Closed
4 tasks
@justinvelluppillai justinvelluppillai added the Needs Review PRs that need a code review label Mar 16, 2022
@justinvelluppillai
Copy link
Contributor Author

Ready for review. I have left the UI tests failing to make it easier to see the differences. I will update them on approval.

sgiehl
sgiehl reviewed Mar 16, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes are looking fine. But shouldn't we maybe increase the contrast of the new placeholder Search text a bit? That one is really hard to read.

@sgiehl sgiehl removed the Needs Review PRs that need a code review label Mar 16, 2022
@justinvelluppillai
Copy link
Contributor Author

justinvelluppillai commented Mar 16, 2022 •
edited

I guess the #d1d1d1 comes from materialize or another include and is used elsewhere. I'll override it for this to #a9a9a9

@justinvelluppillai justinvelluppillai added the Needs Review PRs that need a code review label Mar 16, 2022
@peterhashair
Copy link
Contributor

Coupe screenshots maybe need an update, but other than that looks good to me.

@justinvelluppillai justinvelluppillai merged commit fd8ee23 into 4.x-dev Mar 17, 2022
@justinvelluppillai justinvelluppillai deleted the j-18934 branch March 17, 2022 02:40
@justinvelluppillai justinvelluppillai removed the Needs Review PRs that need a code review label Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl left review comments

@peterhashair peterhashair peterhashair approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Matomo knowledgebase discoverability improvements
3 participants
@justinvelluppillai @peterhashair @sgiehl