Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix added to replace translation strings with %% to % #18940

Merged
merged 2 commits into from Mar 15, 2022

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Fix added to replace translation strings with %% to %

Eg: piwik_translations['HeatmapSessionRecording_HeatmapSampleRateHelp']
Also known as 'traffic'. When you select 100%%, all visitors that visit the selected target page will be recorded. When you select for example 10%%, only every 10th visitor will be recorded. The lower the percentage you select, the longer it will take to reach the selected sample limit.

we have similar replace on server side added same in JS

Review

@AltamashShaikh AltamashShaikh added the Needs Review PRs that need a code review label Mar 14, 2022
@sgiehl sgiehl added the c: i18n For issues around internationalisation and localisation. label Mar 15, 2022
@sgiehl sgiehl added this to the 4.9.0 milestone Mar 15, 2022
@sgiehl sgiehl merged commit afbe9c2 into 4.x-dev Mar 15, 2022
@sgiehl sgiehl deleted the fix-transaltion-string-replace branch March 15, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: i18n For issues around internationalisation and localisation. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants