Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[updates]update Jquery-UI js to 1.13.1 fixing a bug #18936

Merged
merged 10 commits into from Mar 17, 2022
Merged

[updates]update Jquery-UI js to 1.13.1 fixing a bug #18936

merged 10 commits into from Mar 17, 2022

Conversation

peterhashair
Copy link
Contributor

@peterhashair peterhashair commented Mar 14, 2022

Description:

Fixes: #18916

This error is caused by Jquery remove function, remove also tries to remove the tooltip, but since the widget is reloaded the tooltip is not ready yet.

The error line is here, this._find( target ) null. Should be

if (this._find( target ).tooltip) {
 this._removeTooltip( this._find( target ).tooltip );
}

Extend the Jquery function. If that need applies globally, maybe need to move the code to a global JS.

this._removeTooltip( this._find( target ).tooltip );

Review

add try catch on the tooltip
@peterhashair peterhashair added this to the 4.9.0 milestone Mar 14, 2022
Peter added 3 commits March 15, 2022 11:17
add try catch on paraseItem
update live
@peterhashair peterhashair added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Mar 14, 2022
Peter added 4 commits March 15, 2022 13:12
remove `remove` function
revert changes
update destroy
@peterhashair peterhashair removed the Needs Review PRs that need a code review label Mar 15, 2022
extend Jquery _registerCloseHandlers
@peterhashair peterhashair added the Needs Review PRs that need a code review label Mar 16, 2022
@sgiehl
Copy link
Member

sgiehl commented Mar 16, 2022

@peterhashair Seems that has been fixed in jQueryUI 1.13.1. See jquery/jquery-ui#1994
We have still 1.13.0. included. So a npm update for jquery-ui-dist might fix that as well.

@sgiehl sgiehl removed the Needs Review PRs that need a code review label Mar 16, 2022
@peterhashair
Copy link
Contributor Author

peterhashair commented Mar 16, 2022

@sgiehl yes, update npm package to 1.13.1

update Jquery to 1.13.1
@peterhashair peterhashair changed the title add try catch on the tooltip [updates]update Jquery-UI js to 1.13.1 fixing a bug Mar 16, 2022
@sgiehl sgiehl merged commit 6b01674 into 4.x-dev Mar 17, 2022
@sgiehl sgiehl deleted the m-18916 branch March 17, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard: Real time visitors trigger javascript error when refreshing
2 participants