New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[updates]update Jquery-UI js to 1.13.1 fixing a bug #18936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add try catch on the tooltip
peterhashair
added
Needs Review
PRs that need a code review
not-in-changelog
For issues or pull requests that should not be included in our release changelog on matomo.org.
labels
Mar 14, 2022
remove `remove` function
revert changes
update destroy
extend Jquery _registerCloseHandlers
@peterhashair Seems that has been fixed in jQueryUI 1.13.1. See jquery/jquery-ui#1994 |
@sgiehl yes, update npm package to 1.13.1 |
update Jquery to 1.13.1
peterhashair
changed the title
add try catch on the tooltip
[updates]update Jquery-UI js to 1.13.1 fixing a bug
Mar 16, 2022
sgiehl
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
not-in-changelog
For issues or pull requests that should not be included in our release changelog on matomo.org.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes: #18916
This error is caused by Jquery remove function, remove also tries to remove the tooltip, but since the widget is reloaded the tooltip is not ready yet.
The error line is here,
this._find( target )
null. Should beExtend the Jquery function. If that need applies globally, maybe need to move the code to a global JS.
matomo/node_modules/jquery-ui-dist/jquery-ui.js
Line 18874 in f3c9ee7
Review