@diosmosis opened this Pull Request on March 12th 2022 Member

Description:

The current asset removal functionality does not take into account JS chunks, this PR fixes that. This lead to inaccurate JS chunk file sizes when switching between branches, which I noticed.

Review

@sgiehl commented on March 14th 2022 Member

@diosmosis as you are on that part again. Could you please check why the tests on PHP8 are failing? It seems to be related to the manipulation of $GLOBALS['MATOMO_PLUGIN_DIRS'] in the tests you had added in #18761 .

@diosmosis commented on March 15th 2022 Member

@sgiehl should be fixed

This Pull Request was closed on March 15th 2022
Powered by GitHub Issue Mirror