New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate custom dimension management #18926
Conversation
@diosmosis there are a few todo comments left over in the code. Is anything still left over there, or can those comments simply be removed? |
@sgiehl removed them |
@sgiehl applied fixes |
Co-authored-by: Stefan Giehl <stefan@matomo.org>
@sgiehl removed the extra translation |
manuallyTrackCodeViaJs(dimension: CustomDimension) { | ||
return `_paq.push(['setCustomDimension', ${dimension.idcustomdimension}, ` | ||
+ `'${translate('CustomDimensions_ExampleValue')}']);`; | ||
}, | ||
manuallyTrackCodeViaPhp(dimension: CustomDimension) { | ||
return `$tracker->setCustomDimension('${dimension.idcustomdimension}', ` | ||
+ `'${translate('CustomDimensions_ExampleValue')}');`; | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, fixed, apologies for the back & forth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually they should be methods, not yet fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be fixed in latest commit
Description:
Changes:
/list
).(4.x-dev)
Review