Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Losing custom dimensions access when adding view rights #18919

Open
mjschuurman opened this issue Mar 10, 2022 · 1 comment
Open

Losing custom dimensions access when adding view rights #18919

mjschuurman opened this issue Mar 10, 2022 · 1 comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
For Prioritization

Comments

@mjschuurman
Copy link

mjschuurman commented Mar 10, 2022 •
edited

Expected Behavior

When I add view right for Website Y to a user that has Admin rights to another website X then I expect the custom dimensions tab in the settings menu not to disappear. This also corresponde to the documentation at https://matomo.org/docs/custom-dimensions/
" They can be edited by anyone having at least ‘Write’ or ‘Admin’ access for a specific website."

Current Behavior

When I add view right for Website Y to a user that has Admin rights to another website X the custom dimension access rights are withdrawn.

Possible Solution

Implement the expected behavior.

Steps to Reproduce (for Bugs)

  1. Create a user peterpan with only admin access to a single website X
  2. Login as user peterpan and you can see after clicking the cogwheel the user has access to 'custom dimensions'
  3. Add additional view rights for this user to another website Y
  4. Login as user peterpan and click the cogwheel, you now see the 'custom dimensions' tab item is gone

Context

We want a user with admin rights for site X and view rights for site Y to still be able to add dimensions.

Your Environment

  • Matomo Version: 4.8.0
  • PHP Version: 8.0.15
  • Server Operating System: Debian 11 (bullseye)
  • Additionally installed plugins: Premium Bundle
  • Browser: Chrome
  • Operating System: Ubuntu
@mjschuurman mjschuurman added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Mar 10, 2022
@sgiehl
Copy link
Member

sgiehl commented Nov 13, 2022

The menu entry is actually only visible if the current user has at least write access to the idSite given in the url parameters. So simply chaning the url parameter should show the menu again.
Nevertheless we should change the behaviour so the menu entry is visible as soon as the user has at least write access to any website.

@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Nov 13, 2022
@sgiehl sgiehl added this to the For Prioritization milestone Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
For Prioritization
Development

No branches or pull requests
2 participants
@mjschuurman @sgiehl