Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal widget delete confirmation dialog should be directly over the widget #1891

Closed
anonymous-matomo-user opened this issue Dec 14, 2010 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@anonymous-matomo-user
Copy link

The confirmation dialog [yes/no] when deleting a widget is shown at the top of the page. This is not necessarily obvious/easy to see. It should be shown on top of the widget you're trying to delete, instead.

Alternatively/ideally, it should not even be required; it should be an "undo" dialog: http://www.alistapart.com/articles/neveruseawarning

@robocoder
Copy link
Contributor

re: position

jquery-ui doesn't have a setting to position it relative to a widget/element.

The confirmation should be centered in the middle of the viewport. (That's the default jquery-ui behaviour.) Not sure why it has shifted so much (even on trunk).

re: undo

Maintaining an undo stack (i.e., previous state information) is non-trivial. PHP is basically stateless (it frees/releases resources at the end of a request); similarly, when the browser loads a new page.

It's more complicated than it might appear at first glance. You also have to factor in that users oftentimes open multiple tabs to their Piwik dashboard. "Undo" would have to be maintained per browser tab or window.

@julienmoumne
Copy link
Member

Maybe it doesn't have to be a history undo but a simple one-action undo.

Use case :

  1. The user mistakenly removes a widget and notices it immediately

  2. The user clicks "undo", the widget is restored

Between 1) and 2), if the user leaves the page or do another action then the undo is lost. No big deal, it's only a widget.

This mechanism would be implemented in JavaScript solely.

@mattab
Copy link
Member

mattab commented Jan 17, 2011

I think the widget modal is easy to spot as it displays in the top middle of the screen on top of a grey background.

@anonymous-matomo-user anonymous-matomo-user added this to the Future releases milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

No branches or pull requests

4 participants