Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on upgrade: Call to undefined method Piwik\Plugins\Overlay\Overlay::isOverlayRequest() #18906

Closed
unhammer opened this issue Mar 9, 2022 · 5 comments
Labels
worksforme The issue cannot be reproduced and things work as intended.

Comments

@unhammer
Copy link

unhammer commented Mar 9, 2022

Expected Behavior

Upgrading to 4.8.0 from the web ui.

Current Behavior

After it seems done, I got a 500, and on trying to log in I see An Error occurred and Call to undefined method Piwik\Plugins\Overlay\Overlay::isOverlayRequest()

Steps to Reproduce (for Bugs)

  1. Be on some older version (my CHANGELOG file says 4.6)
  2. Try to upgrade to 4.8.0 from web ui

Your Environment

  • Matomo Version: possibly 4.6 according to CHANGELOG
  • PHP Version: 7.4.25
  • Server Operating System: debian 10 buster
  • Additionally installed plugins: none that I know of

I see nothing from https://forum.matomo.org/search?q=isOverlayRequest

@unhammer unhammer added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Mar 9, 2022
@unhammer
Copy link
Author

unhammer commented Mar 9, 2022

fixed by manually wget+unzipping over ssh, as described in
https://matomo.org/docs/update/#the-manual-three-step-update
Maybe it was just some glitch with the auto-unzipping on the server? I'll just close this, probably not a bug if it's just me :-)

@unhammer unhammer closed this as completed Mar 9, 2022
@sgiehl sgiehl added worksforme The issue cannot be reproduced and things work as intended. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Mar 9, 2022
@756gzdz5
Copy link

@unhammer what did you unzip? I'm having the same issue.

@sgiehl
Copy link
Member

sgiehl commented Mar 10, 2022

@756gzdz5 It seems for some reason the file plugins/Overlay/Overlay.php hasn't been updated correctly. You can download the official release zip and overwrite the contents on your webserver to fix that.

@756gzdz5
Copy link

@sgiehl Thank you, now I got it.

@unhammer
Copy link
Author

unhammer commented Mar 10, 2022

@756gzdz5 edited my comment for future readers, I meant following https://matomo.org/docs/update/#the-manual-three-step-update instead of "one-click update" :) Interesting that you got the same error, maybe this is a real bug after all?

@sgiehl I think it's more than just that file that wasn't updated correctly (since my CHANGELOG still said 4.6), that's just the first file that lead to an error. Just in case someone thinks they can update just that one file, that's probably not going to work, need to unzip everything ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Development

No branches or pull requests

3 participants