Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the _pk_id in the past when deleting cookie. #18902

Closed
jmumby opened this issue Mar 9, 2022 · 1 comment · Fixed by #18905
Closed

Set the _pk_id in the past when deleting cookie. #18902

jmumby opened this issue Mar 9, 2022 · 1 comment · Fixed by #18905
Assignees
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone

Comments

@jmumby
Copy link

jmumby commented Mar 9, 2022

When the _pk_id cookie is set to expire it sets the current date. When tools like cookiebot scans for cookies and have a timing anomaly potentially the cookie can still seem active.

Can we have the cookie set to a time in the past to avoid this issue.

@jmumby jmumby added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Mar 9, 2022
@aleksijohansson
Copy link
Contributor

It seems that the cookies are set to expire in the past when deleted, but only 86400 milliseconds (~86 seconds). Since there can be 26 hours at most between timezones, maybe setting the cookies to expire a good 36 hours in the past would be a safe bet. PR incoming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants