use correct cache buster in core/View.php #18895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es, which is different in development mode
There was a problem hiding this comment.
@diosmosis
This solves the issue
I just took a recent pull of TagManager and tried to click on Install Code, got this
I checked out to this branch and did a refresh and its loads properly as expected
AltamashShaikh
approved these changes
Mar 8, 2022
sgiehl
added
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The cachebuster set in render() does not appear to be used for JS files, which is different in development mode. Might be the cause of reloads not reloading JS files when switching branches.
CC @AltamashShaikh
Review