Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] fix typo in directive name causing strange regressions #18894

Merged
merged 3 commits into from Mar 8, 2022
Merged

[Vue] fix typo in directive name causing strange regressions #18894

merged 3 commits into from Mar 8, 2022

Conversation

diosmosis
Copy link
Member

Description:

The copy-paste error overwrites expandOnClick causing some strange looking regressions.

Review

@diosmosis diosmosis added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Mar 8, 2022
@diosmosis diosmosis added this to the 4.9.0 milestone Mar 8, 2022
@diosmosis diosmosis merged commit a3bfb7b into 4.x-dev Mar 8, 2022
@diosmosis diosmosis deleted the vue-goal-page-link-regression branch March 8, 2022 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhashair peterhashair peterhashair approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @peterhashair