Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix removing existing notifications with same id #18891

Closed
wants to merge 2 commits into from
Closed

Fix removing existing notifications with same id #18891

wants to merge 2 commits into from

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 7, 2022 •
edited

Description:

Notification were added with the property notificationId here, but the methods for removing old notifications were actually checking for id

Review

@sgiehl sgiehl closed this Mar 7, 2022
@sgiehl sgiehl deleted the vuenotification branch March 7, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sgiehl