Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate config option serve_widget_and_data ? #1889

Closed
mattab opened this issue Dec 14, 2010 · 3 comments
Closed

Deprecate config option serve_widget_and_data ? #1889

mattab opened this issue Dec 14, 2010 · 3 comments
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Dec 14, 2010

Should we deprecate config option serve_widget_and_data ?

; If set to 0, Flash widgets require separate HTTP requests
; (i.e., one request to load the JavaScript which instantiates Open Flash Chart; the other request is made by OFC to download the JSON data for the chart)
; If set to 1, Piwik uses a single HTTP request per Flash widget to serve both the widget and data
serve_widget_and_data = 1

I can't think of a case where this would be useful? thoughts?

@robocoder
Copy link
Contributor

I found it useful when checking for regressions with the Flash widgets. Maybe move it to the [Debug] section of global.ini.php (similar to disable_merged_assets)?

@robocoder
Copy link
Contributor

(In [3488]) fixes #1889 - serve_widget_and_data now a Debug option

@robocoder
Copy link
Contributor

(In [3489]) refs #1889 - rename (and invert logic) for consistency with other debug options

@mattab mattab added this to the Piwik 1.1 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

2 participants