Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible warning in Url::isValidHost #18887

Merged
merged 1 commit into from Mar 7, 2022
Merged

Fix possible warning in Url::isValidHost #18887

merged 1 commit into from Mar 7, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 4, 2022

Description:

fixes #18885

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Mar 4, 2022
@sgiehl sgiehl added this to the 4.8.0 milestone Mar 4, 2022
@justinvelluppillai justinvelluppillai merged commit ad1d93c into next_release Mar 7, 2022
@justinvelluppillai justinvelluppillai deleted the fixwarning branch March 7, 2022 01:18
justinvelluppillai added a commit that referenced this pull request Mar 8, 2022
@justinvelluppillai @sgiehl @bx80
Merge RC patches back to main branch (#18901)
7255b44 
* Update version to 4.8.0-rc1

* Fix possible warning in Url::isValidHost (#18887)

* Handle case only file name updates on case insensitive file systems (#18865)

* Added unit test for case-sensitive unlink

* Use case-insensitive comparison in directoryDiff() if a case-insensitive filesystem is detected

* Fix misleading method name

* Update tests/PHPUnit/Unit/FilesystemTest.php

Co-authored-by: Justin Velluppillai <justin@innocraft.com>

* Update tests/PHPUnit/Unit/FilesystemTest.php

Co-authored-by: Justin Velluppillai <justin@innocraft.com>

Co-authored-by: Justin Velluppillai <justin@innocraft.com>

* Update version to 4.8.0 (#18893)

Co-authored-by: Stefan Giehl <stefan@matomo.org>
Co-authored-by: Ben Burgess <88810029+bx80@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvelluppillai justinvelluppillai justinvelluppillai approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @justinvelluppillai