Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] Fix regression in plugin order determination, new param keepUnresolved is not used in function. #18886

Merged
merged 1 commit into from Mar 6, 2022
Merged

[Vue] Fix regression in plugin order determination, new param keepUnresolved is not used in function. #18886

merged 1 commit into from Mar 6, 2022

Conversation

diosmosis
Copy link
Member

Description:

Refs #18761

This causes the vue:build command to fail. Added tests for this as well.

Review

@diosmosis diosmosis added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Mar 4, 2022
@diosmosis diosmosis added this to the 4.9.0 milestone Mar 4, 2022
@diosmosis diosmosis merged commit d25af6d into 4.x-dev Mar 6, 2022
@diosmosis diosmosis deleted the vue-plugin-order-regression branch March 6, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhashair peterhashair peterhashair approved these changes

@sgiehl sgiehl Awaiting requested review from sgiehl

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @peterhashair