@AltamashShaikh opened this Issue on March 1st 2022 Contributor

The sparkline do not show edge nodes correctly, it displays the node partially

Expected Behavior

Earlier the nodes used to display fully
MediaAnalytics_page_video_subtable_row_evolution _correct

Current Behavior

The node edges are displayed partially
MediaAnalytics_page_video_subtable_row_evolution_wrong

Steps to Reproduce (for Bugs)

Visit https://demo.matomo.cloud/index.php?module=CoreHome&action=index&idSite=1&period=day&date=yesterday#?idSite=1&period=day&date=yesterday&segment=&category=General_Visitors&subcategory=General_Overview and check the sparkline under Visits Overview

@sgiehl commented on March 1st 2022 Member

This seems to be caused by some changes in the library we are using:
https://github.com/davaxi/Sparkline/blob/master/src/Sparkline/FormatTrait.php#L228
I guess this was changed due to PHP 8 incompatibilities. It actually before did an implicit round, while it now does a ceil, causing the generated points to be a bit wider...
Can propose a fix for the used library, but might need one or two hours to also provide some tests, to ensure that won't happen again in the future...

Powered by GitHub Issue Mirror