Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sparkline nodes not showing edge nodes properly #18863

Open
AltamashShaikh opened this issue Mar 1, 2022 · 1 comment
Open

Sparkline nodes not showing edge nodes properly #18863

AltamashShaikh opened this issue Mar 1, 2022 · 1 comment
Assignees
@sgiehl
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall.
Milestone
For Prioritization

Comments

@AltamashShaikh
Copy link
Contributor

The sparkline do not show edge nodes correctly, it displays the node partially

Expected Behavior

Earlier the nodes used to display fully
MediaAnalytics_page_video_subtable_row_evolution _correct

Current Behavior

The node edges are displayed partially
MediaAnalytics_page_video_subtable_row_evolution_wrong

Steps to Reproduce (for Bugs)

Visit https://demo.matomo.cloud/index.php?module=CoreHome&action=index&idSite=1&period=day&date=yesterday#?idSite=1&period=day&date=yesterday&segment=&category=General_Visitors&subcategory=General_Overview and check the sparkline under Visits Overview
@AltamashShaikh AltamashShaikh added c: Design / UI For issues that impact Matomo's user interface or the design overall. Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Mar 1, 2022
@sgiehl
Copy link
Member

sgiehl commented Mar 1, 2022

This seems to be caused by some changes in the library we are using:
https://github.com/davaxi/Sparkline/blob/master/src/Sparkline/FormatTrait.php#L228
I guess this was changed due to PHP 8 incompatibilities. It actually before did an implicit round, while it now does a ceil, causing the generated points to be a bit wider...
Can propose a fix for the used library, but might need one or two hours to also provide some tests, to ensure that won't happen again in the future...

@sgiehl sgiehl mentioned this issue Nov 9, 2022
Open
@sgiehl sgiehl self-assigned this Nov 9, 2022
@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall.
Projects
None yet
Milestone
For Prioritization
Development

No branches or pull requests
3 participants
@sgiehl @AltamashShaikh @innocraft-automation