Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update installation newsletter checkbox text #18861

Merged
merged 2 commits into from Mar 4, 2022
Merged

Update installation newsletter checkbox text #18861

merged 2 commits into from Mar 4, 2022

Conversation

peterhashair
Copy link
Contributor

Description:

Fixes: #18787

Update newsletter installs newsletter checkbox label as a screenshot.

image

Review

Update en.json
ec04e16 
update long
@peterhashair peterhashair added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 28, 2022
@peterhashair peterhashair added this to the 4.9.0 milestone Feb 28, 2022
update ui
760203c 
update ui
@sgiehl
Copy link
Member

sgiehl commented Mar 1, 2022

@mattab could you maybe have a quick look, if the changes are what you were looking for with #18787 ?

@sgiehl sgiehl requested a review from mattab March 1, 2022 09:45
@sgiehl sgiehl merged commit 2aa54fd into 4.x-dev Mar 4, 2022
@sgiehl sgiehl deleted the m-18787 branch March 4, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattab mattab mattab approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.9.0
Development

Successfully merging this pull request may close these issues.

Clarify the Newsletter Opt-in message during installation
3 participants
@peterhashair @sgiehl @mattab