Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] make sure segment is encoded properly in URL when AjaxHelper.fetch is used #18844

Merged
merged 1 commit into from Feb 24, 2022
Merged

[Vue] make sure segment is encoded properly in URL when AjaxHelper.fetch is used #18844

merged 1 commit into from Feb 24, 2022

Conversation

diosmosis
Copy link
Member

Description:

Fixes #18783

CC @sgiehl

Review

@diosmosis diosmosis added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Feb 24, 2022
@diosmosis diosmosis added this to the 4.8.0 milestone Feb 24, 2022
sgiehl
sgiehl approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works 👍

@sgiehl sgiehl merged commit 7b09d5e into 4.x-dev Feb 24, 2022
@sgiehl sgiehl deleted the vue-segment-fetch-encode branch February 24, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

Comparing two segments in goals, sets the graph to all zeros for the first segment
2 participants
@diosmosis @sgiehl