Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward templateFile/component properties in MultiPairField/FieldArray and handle in FormField #18841

Merged
merged 1 commit into from Feb 24, 2022

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Feb 24, 2022

Description:

Since existing php setting code can still use templateFile, we need to handle it in Vue code for now, since not all of them will change even though the core code may use Vue to display those settings. And of course we want to forward those values in MultiPairField/FieldArray.

NOTE: This issue is currently visible in tagmanager edit variable section where a custom component value is used for most inputs (to be able to select variables to use).

Review

…y and handle in FormField.vue since existing php setting code can still use templateFile.
@diosmosis diosmosis added Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Feb 24, 2022
@diosmosis diosmosis added this to the 4.8.0 milestone Feb 24, 2022
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if tests are passed.

@sgiehl sgiehl merged commit bffce0b into 4.x-dev Feb 24, 2022
@sgiehl sgiehl deleted the vue-dynamic-setting-template-file branch February 24, 2022 08:52
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants